Skip to content

fix: [Platform:StackManagement:SnapshotAndRestore:Add repository page]Missing error warning announcement#220633

Merged
alexwizp merged 3 commits intoelastic:mainfrom
alexwizp:9May
May 9, 2025
Merged

fix: [Platform:StackManagement:SnapshotAndRestore:Add repository page]Missing error warning announcement#220633
alexwizp merged 3 commits intoelastic:mainfrom
alexwizp:9May

Conversation

@alexwizp
Copy link
Copy Markdown
Contributor

@alexwizp alexwizp commented May 9, 2025 •
edited by kibanamachine
Loading

Closes: #219355
Closes: #219345

Summary

This PR improves accessibility for users relying on assistive technologies for: Analytics → Stack Management → Snapshot and Restore by addressing the following:

  1. Screen Reader Announcements for Error Warnings
  2. Duplication of announcement

@alexwizp alexwizp added Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes backport:prev-major labels May 9, 2025
@alexwizp alexwizp marked this pull request as ready for review May 9, 2025 09:59
@alexwizp alexwizp requested a review from a team as a code owner May 9, 2025 09:59
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented May 9, 2025

Pinging @elastic/kibana-accessibility (Project:Accessibility)

SoniaSanzV
SoniaSanzV approved these changes May 9, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@SoniaSanzV SoniaSanzV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for addressing this, lgtm!

@alexwizp alexwizp enabled auto-merge (squash) May 9, 2025 11:38
@alexwizp alexwizp merged commit 9a2dc53 into elastic:main May 9, 2025
9 checks passed
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 9, 2025

Starting backport for target branches: 8.17, 8.18, 8.19

https://github.com/elastic/kibana/actions/runs/14930345541

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented May 9, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #114 / Rules Management - Rule import export API @ess @serverless @skipInServerlessMKI import_rules importing rules with an index @skipInServerless migrate pre-8.0 action connector ids should be imported into the non-default space should import a non-default-space 7.16 rule with a connector made in the non-default space
  • [job] [logs] FTR Configs #129 / serverless observability UI discover/observabilitySolution/logs observability logs getDocViewer renders docViewer should toggle to quality issue accordion when 1st stacktrace and then quality issue control is clicked for different row

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
snapshotRestore 248.2KB 248.3KB +187.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
esUiShared 88.4KB 88.4KB +13.0B

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 9, 2025
@alexwizp
fix: [Platform:StackManagement:SnapshotAndRestore:Add repository page…
7d628ba 
…]Missing error warning announcement (elastic#220633)

Closes: elastic#219355
Closes: elastic#219345

## Summary

This PR improves accessibility for users relying on assistive
technologies for: `Analytics → Stack Management → Snapshot and Restore`
by addressing the following:

1. Screen Reader Announcements for Error Warnings
2. Duplication of announcement

(cherry picked from commit 9a2dc53)
@kibanamachine kibanamachine mentioned this pull request May 9, 2025
Closed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 9, 2025
@alexwizp
fix: [Platform:StackManagement:SnapshotAndRestore:Add repository page…
0bf16ca 
…]Missing error warning announcement (elastic#220633)

Closes: elastic#219355
Closes: elastic#219345

## Summary

This PR improves accessibility for users relying on assistive
technologies for: `Analytics → Stack Management → Snapshot and Restore`
by addressing the following:

1. Screen Reader Announcements for Error Warnings
2. Duplication of announcement

(cherry picked from commit 9a2dc53)
@kibanamachine kibanamachine mentioned this pull request May 9, 2025
Closed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 9, 2025
@alexwizp
fix: [Platform:StackManagement:SnapshotAndRestore:Add repository page…
3477ab9 
…]Missing error warning announcement (elastic#220633)

Closes: elastic#219355
Closes: elastic#219345

## Summary

This PR improves accessibility for users relying on assistive
technologies for: `Analytics → Stack Management → Snapshot and Restore`
by addressing the following:

1. Screen Reader Announcements for Error Warnings
2. Duplication of announcement

(cherry picked from commit 9a2dc53)
@kibanamachine kibanamachine mentioned this pull request May 9, 2025
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 9, 2025

💚 All backports created successfully

Status Branch Result
✅ 8.17
✅ 8.18
✅ 8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 9, 2025
@kibanamachine @alexwizp
[8.19] fix: [Platform:StackManagement:SnapshotAndRestore:Add reposito…
ed3b81c 
…ry page]Missing error warning announcement (#220633) (#220663)

# Backport

This will backport the following commits from `main` to `8.19`:
- [fix: [Platform:StackManagement:SnapshotAndRestore:Add repository
page]Missing error warning announcement
(#220633)](#220633)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Alexey
Antonov","email":"alexwizp@gmail.com"},"sourceCommit":{"committedDate":"2025-05-09T13:44:30Z","message":"fix:
[Platform:StackManagement:SnapshotAndRestore:Add repository page]Missing
error warning announcement (#220633)\n\nCloses: #219355\nCloses:
#219345\n\n\n## Summary\n\nThis PR improves accessibility for users
relying on assistive\ntechnologies for: `Analytics → Stack Management →
Snapshot and Restore`\nby addressing the following:\n\n1. Screen Reader
Announcements for Error Warnings\n2. Duplication of
announcement","sha":"9a2dc53b82c58032c3d3e56e1ffc11e755caea01","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","backport:prev-major","v9.1.0"],"title":"fix:
[Platform:StackManagement:SnapshotAndRestore:Add repository page]Missing
error warning
announcement","number":220633,"url":"https://github.com/elastic/kibana/pull/220633","mergeCommit":{"message":"fix:
[Platform:StackManagement:SnapshotAndRestore:Add repository page]Missing
error warning announcement (#220633)\n\nCloses: #219355\nCloses:
#219345\n\n\n## Summary\n\nThis PR improves accessibility for users
relying on assistive\ntechnologies for: `Analytics → Stack Management →
Snapshot and Restore`\nby addressing the following:\n\n1. Screen Reader
Announcements for Error Warnings\n2. Duplication of
announcement","sha":"9a2dc53b82c58032c3d3e56e1ffc11e755caea01"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/220633","number":220633,"mergeCommit":{"message":"fix:
[Platform:StackManagement:SnapshotAndRestore:Add repository page]Missing
error warning announcement (#220633)\n\nCloses: #219355\nCloses:
#219345\n\n\n## Summary\n\nThis PR improves accessibility for users
relying on assistive\ntechnologies for: `Analytics → Stack Management →
Snapshot and Restore`\nby addressing the following:\n\n1. Screen Reader
Announcements for Error Warnings\n2. Duplication of
announcement","sha":"9a2dc53b82c58032c3d3e56e1ffc11e755caea01"}}]}]
BACKPORT-->

Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
@kibanamachine kibanamachine mentioned this pull request May 9, 2025
Merged
2 tasks
kdelemme pushed a commit to kdelemme/kibana that referenced this pull request May 9, 2025
@alexwizp @kdelemme
fix: [Platform:StackManagement:SnapshotAndRestore:Add repository page…
0a78e20 
…]Missing error warning announcement (elastic#220633)

Closes: elastic#219355
Closes: elastic#219345


## Summary

This PR improves accessibility for users relying on assistive
technologies for: `Analytics → Stack Management → Snapshot and Restore`
by addressing the following:

1. Screen Reader Announcements for Error Warnings
2. Duplication of announcement
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 12, 2025
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 12, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @alexwizp

2 similar comments
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 13, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @alexwizp

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 14, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @alexwizp

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 15, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @alexwizp

2 similar comments
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 16, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @alexwizp

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 19, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @alexwizp

@alexwizp alexwizp added backport:version Backport to applied version labels and removed backport missing Added to PRs automatically when the are determined to be missing a backport. backport:prev-major labels May 20, 2025
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 20, 2025

Starting backport for target branches: 8.19

https://github.com/elastic/kibana/actions/runs/15134657931

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 20, 2025

💔 All backports failed

Status Branch Result
❌ 8.19 Cherrypick failed because the selected commit (9a2dc53) is empty. It looks like the commit was already backported in #220663

Manual backport

To create the backport manually run:

node scripts/backport --pr 220633

Questions ?

Please refer to the Backport tool documentation

akowalska622 pushed a commit to akowalska622/kibana that referenced this pull request May 29, 2025
@alexwizp @akowalska622
fix: [Platform:StackManagement:SnapshotAndRestore:Add repository page…
6e1fd2d 
…]Missing error warning announcement (elastic#220633)

Closes: elastic#219355
Closes: elastic#219345


## Summary

This PR improves accessibility for users relying on assistive
technologies for: `Analytics → Stack Management → Snapshot and Restore`
by addressing the following:

1. Screen Reader Announcements for Error Warnings
2. Duplication of announcement
qn895 pushed a commit to qn895/kibana that referenced this pull request Jun 3, 2025
@alexwizp @qn895
fix: [Platform:StackManagement:SnapshotAndRestore:Add repository page…
fbe336a 
…]Missing error warning announcement (elastic#220633)

Closes: elastic#219355
Closes: elastic#219345


## Summary

This PR improves accessibility for users relying on assistive
technologies for: `Analytics → Stack Management → Snapshot and Restore`
by addressing the following:

1. Screen Reader Announcements for Error Warnings
2. Duplication of announcement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SoniaSanzV SoniaSanzV SoniaSanzV approved these changes

Assignees

No one assigned

Labels

backport:version Backport to applied version labels Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes v8.19.0 v9.1.0

Projects

None yet

Milestone

No milestone

4 participants

@alexwizp @elasticmachine @kibanamachine @SoniaSanzV